Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified the verbos status #87

Merged
merged 5 commits into from
May 30, 2024
Merged

Conversation

XYangXRay
Copy link

In chx_generic_functions -> get_sid_filenames(...) the status 'success' should NOT depend on whether 'verbose' is True or False. This was fixed by Lutz in the current pr.

@XYangXRay XYangXRay requested a review from mrakitin May 15, 2024 18:56
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply pre-commit, then it can be ready to merge/be released.

@XYangXRay XYangXRay requested a review from mrakitin May 22, 2024 19:44
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @XYangXRay.

@mrakitin mrakitin merged commit 9e445ac into main May 30, 2024
12 checks passed
@mrakitin mrakitin deleted the updates-20240515-generic-function branch May 30, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants